Major codebase refactoring #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Separates SyncPull and AsyncPull
Separates Sync/Async pulls
* Removes push.mail.GMail * Removes push.notify.Pushbullet
Two different types by now: * General (non api) runner to run the async engine in it's own main loop * API Aware runner to spin off an api and run the engine in the apis event loop Migrates from attrs to pydantic for container objects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the plugin interface to better distinguish sync / async plugins to provide a simpler end-user interface
Introduces runner to start up an application context
Two different types by now:
own main loop
the apis event loop
Migrates from attrs to pydantic for container objects
Updates all dependencies to latest constrained version (if possible)
Removes
enable_swaggerfrom the api configuration propertiesReplaces
auto_strdecorator byReprMixinbased on basic_repr fromfastcorepackage