Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] feat(VoiceStateUpdate): handle deaf & mute events #291

Closed
wants to merge 4 commits into from
Closed

[WIP] feat(VoiceStateUpdate): handle deaf & mute events #291

wants to merge 4 commits into from

Conversation

Hazmi35
Copy link
Owner

@Hazmi35 Hazmi35 commented Dec 17, 2020

No description provided.

@Hazmi35
Copy link
Owner Author

Hazmi35 commented Dec 19, 2020

This PR won't land on version 4.25.0, as it's still incomplete

@Hazmi35 Hazmi35 force-pushed the feat/handle-deaf-mute-events branch from 2f8d13c to 3704d3e Compare January 1, 2021 23:44
@Hazmi35
Copy link
Owner Author

Hazmi35 commented Jan 2, 2021

NOTE: It's still WIP. We just need to test this and make sure it doesn't break old functionality then clean the code.

@Hazmi35 Hazmi35 force-pushed the feat/handle-deaf-mute-events branch from 206ba98 to 5aa1b8c Compare January 2, 2021 00:31
@Hazmi35
Copy link
Owner Author

Hazmi35 commented Jan 5, 2021 •
edited
Loading

Tests:

  • If the bot gets muted, it should do a queue timeout.
  • If all people in VC are deafened, the bot should do a queue timeout.
  • All old functionality is working as intended.

@Hazmi35
Copy link
Owner Author

Hazmi35 commented Jan 6, 2021

There's a problem when the bot is server muted before the first song plays. this won't land in version 4.26.0

@Hazmi35
Copy link
Owner Author

Hazmi35 commented Aug 8, 2021

This is too problematic, this requires a rewrite, I'll probably consider this functionality in v6

@Hazmi35 Hazmi35 closed this Aug 8, 2021
@Hazmi35 Hazmi35 mentioned this pull request Aug 8, 2021
Open
@Hazmi35 Hazmi35 deleted the feat/handle-deaf-mute-events branch August 8, 2021 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Hazmi35