Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_sentence_ngrams, get_neighbor_sentence_ngrams, same_sentence should be fonduer.utils.data_model_utils.textual? #503

Closed
HiromuHota opened this issue Sep 8, 2020 · 0 comments · Fixed by #505

Comments

@HiromuHota
Copy link
Contributor

Description of the bug

get_sentence_ngrams, get_neighbor_sentence_ngrams, same_sentence are placed under fonduer.utils.data_model_utils.tabular module, but their names sound and their behaviours look textual.

To Reproduce

Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Execute the code '...'
    If necessary, attach example data which can be used to replicate the issue.

Expected behavior

Move them into fonduer.utils.data_model_utils.textual?

Error Logs/Screenshots

If applicable, add error logs or screenshots to help explain your problem.

Environment (please complete the following information)

  • Fonduer Version: 0.8.2

Additional context

Add any other context about the problem here.

HiromuHota pushed a commit to HiromuHota/fonduer that referenced this issue Sep 9, 2020
… to data_model_utils.textual

and deprecated them in data_model_utils.tabular (fix HazyResearch#503)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant