Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add docstring for learning #153

Merged
merged 8 commits into from
Sep 17, 2018
Merged

add docstring for learning #153

merged 8 commits into from
Sep 17, 2018

Conversation

senwu
Copy link
Collaborator

@senwu senwu commented Sep 15, 2018

No description provided.

Copy link
Contributor

@lukehsiao lukehsiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are also still many utilities that do not have documentation. If they are not meant to be public, they should be made private. Otherwise, they should be documented.

For example:

fonduer.learning.utils.print_scores(ntp, nfp, ntn, nfn, title='Scores')
fonduer.learning.utils.binary_scores_from_counts(ntp, nfp, ntn, nfn)
class fonduer.learning.utils.Scorer(test_candidates, test_labels, gold_candidate_set=None)
class fonduer.learning.utils.ModelTester(model_class, model_class_params, params_queue, scores_queue, X_train, X_valid, Y_valid, Y_train=None, b=0.5, beta=1, set_unlabeled_as_neg=True, save_dir='checkpoints', eval_batch_size=None)

All of these init parameters should be documented as well.

src/fonduer/learning/classifier.py Outdated Show resolved Hide resolved
src/fonduer/learning/classifier.py Show resolved Hide resolved
src/fonduer/learning/disc_learning.py Outdated Show resolved Hide resolved
src/fonduer/learning/disc_models/lstm.py Show resolved Hide resolved
@lukehsiao lukehsiao added the docs Related to our documentation label Sep 15, 2018
@lukehsiao lukehsiao added this to the v0.3.0 milestone Sep 15, 2018
@lukehsiao
Copy link
Contributor

Basically, Core Learning Objects are pretty much ready, just want to eliminate kwargs wherever possible.

The Learning Utilities are still missing several docstrings on initilizations for classes and some function parameters.

Copy link
Contributor

@lukehsiao lukehsiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other issue we still need to address is documenting the wrappers for MeTal (LabelAnalyzer and LabelLearner) so that users know what functionality they provide.

Because MeTaL lacks documentation, we may need to do this ourselves for now.

src/fonduer/learning/disc_learning.py Show resolved Hide resolved
src/fonduer/learning/utils.py Outdated Show resolved Hide resolved
src/fonduer/learning/utils.py Outdated Show resolved Hide resolved
@senwu
Copy link
Collaborator Author

senwu commented Sep 16, 2018

Fixed! Merge to docstrings branch if LGTY. Thanks.

@lukehsiao lukehsiao merged commit f594a14 into docstrings Sep 17, 2018
@lukehsiao lukehsiao deleted the learning_docstring branch September 17, 2018 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Related to our documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants