To support ImageMagick7, expand the version range of Wand #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default version of ImageMagick is different among OS.
Currently Fonduer depends on Wand (>=0.4.4, <0.5.0), which does not support ImageMagick7.
This is why we had to install ImageMagick6 on Mac.
Wand 0.5.X supports both ImageMagick6 and 7.
As far as CHANGELOG is concerned, 0.5.X did not introduce breaking changes.
Now is the time to expand the version range of Wand to include 0.5.X.