Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test the 0-index label in valid set and remove the log folder after t… #389

Merged
merged 7 commits into from Apr 7, 2020
Merged

test the 0-index label in valid set and remove the log folder after t… #389

merged 7 commits into from Apr 7, 2020

Conversation

senwu
Copy link
Collaborator

@senwu senwu commented Apr 7, 2020 •
edited

  1. test the 0-index label in valid set.
  2. remove the log folder after the test.

@senwu senwu requested a review from lukehsiao April 7, 2020 18:50
lukehsiao
lukehsiao approved these changes Apr 7, 2020
View reviewed changes
Copy link
Contributor

@lukehsiao lukehsiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if tests pass.

@lukehsiao lukehsiao added this to the v0.8.0 milestone Apr 7, 2020
@lukehsiao lukehsiao self-assigned this Apr 7, 2020
lukehsiao
lukehsiao reviewed Apr 7, 2020
View reviewed changes
tests/e2e/test_e2e.py Outdated Show resolved Hide resolved
@lukehsiao lukehsiao merged commit b55b635 into emmental-5 Apr 7, 2020
@lukehsiao lukehsiao deleted the fix_e2e_test branch April 7, 2020 22:04
lukehsiao pushed a commit that referenced this pull request Apr 7, 2020
@senwu @lukehsiao
test(test_e2e): ensure that 0-index labels are in the valid set (#389)
3391df9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukehsiao lukehsiao lukehsiao approved these changes

Assignees

@lukehsiao lukehsiao

Labels
None yet
Projects
None yet
Milestone
v0.8.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@senwu @lukehsiao