Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate visualizer.get_box in favor of span.get_bbox() #446

Merged
merged 3 commits into from
Jun 13, 2020
Merged

Deprecate visualizer.get_box in favor of span.get_bbox() #446

merged 3 commits into from
Jun 13, 2020

Conversation

HiromuHota
Copy link
Contributor

Fix #445.

@HiromuHota
Copy link
Contributor Author

This fix depends on #444

@senwu
Copy link
Collaborator

senwu commented Jun 13, 2020

#444 is merged!

@HiromuHota HiromuHota marked this pull request as ready for review June 13, 2020 03:05
@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2020 •
edited
Loading

Codecov Report

Merging #446 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #446   +/-   ##
=======================================
  Coverage   83.19%   83.20%           
=======================================
  Files          88       88           
  Lines        4552     4554    +2     
  Branches      837      837           
=======================================
+ Hits         3787     3789    +2     
  Misses        572      572           
  Partials      193      193
Flag Coverage Δ
#unittests 83.20% <100.00%> (+<0.01%) ⬆️
Impacted Files Coverage Δ
src/fonduer/utils/visualizer.py 79.72% <100.00%> (+0.56%) ⬆️

senwu
senwu approved these changes Jun 13, 2020
View reviewed changes
Copy link
Collaborator

@senwu senwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@senwu senwu merged commit 124e626 into HazyResearch:master Jun 13, 2020
@HiromuHota HiromuHota deleted the fix/445 branch June 13, 2020 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@senwu senwu senwu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

visualizer.get_box is a duplicate of utils_visual.bbox_from_span
3 participants
@HiromuHota @senwu @codecov-commenter