Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove visible_columns from DataPanel #125

Merged
merged 3 commits into from Aug 13, 2021
Merged

Remove visible_columns from DataPanel #125

merged 3 commits into from Aug 13, 2021

Conversation

seyuboglu
Copy link
Collaborator

DataPanels no longer rely on visible_columns to create views. This PR removes visible_columns entirely.

Other changes:

  • Improve code coverage
    • Reactivate provenance tests
    • DataPanel batch tests
    • Concat tests
    • Merge tests
  • Remove Identifiers, Splits and Info from DataPanel and AbstractColumn

@codecov-commenter
Copy link

codecov-commenter commented Aug 13, 2021

Codecov Report

Merging #125 (1c5a787) into dev (647c6d3) will increase coverage by 6.01%.
The diff coverage is 92.98%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #125      +/-   ##
==========================================
+ Coverage   77.31%   83.32%   +6.01%     
==========================================
  Files          48       46       -2     
  Lines        3015     2807     -208     
  Branches      515      477      -38     
==========================================
+ Hits         2331     2339       +8     
+ Misses        550      366     -184     
+ Partials      134      102      -32     
Flag Coverage Δ
unittests 83.32% <92.98%> (+6.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
meerkat/mixins/mapping.py 78.18% <ø> (+6.51%) ⬆️
meerkat/mixins/cloneable.py 95.23% <66.66%> (-2.20%) ⬇️
meerkat/pipelines/entitydatapanel.py 71.62% <80.00%> (+0.78%) ⬆️
meerkat/ops/concat.py 94.59% <85.71%> (-5.41%) ⬇️
meerkat/block/manager.py 96.89% <92.85%> (-0.84%) ⬇️
meerkat/datapanel.py 91.19% <97.43%> (+16.95%) ⬆️
meerkat/block/numpy_block.py 93.42% <100.00%> (+0.66%) ⬆️
meerkat/block/pandas_block.py 96.96% <100.00%> (+0.14%) ⬆️
meerkat/columns/abstract.py 83.51% <100.00%> (+0.17%) ⬆️
meerkat/columns/numpy_column.py 87.61% <100.00%> (+0.11%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 647c6d3...1c5a787. Read the comment docs.

@seyuboglu
Copy link
Collaborator Author

Closes #65

@seyuboglu seyuboglu merged commit 0440b6d into dev Aug 13, 2021
@seyuboglu seyuboglu deleted the test-cov branch August 13, 2021 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants