Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

critique? #1

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 26 additions & 3 deletions longest-run.playground/Contents.swift
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,37 @@ This excercise lends itself to TDD and we have provided a few basic tests below.
import Cocoa

func longestRun(whole: String) -> String {
return whole
let sorted = whole.characters.sort()
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duh! this does not give the longest contiguous run, but the most frequent character... oh well...


var currentRunCharacter = sorted.first
var currentRun = 0
var longestRunCharacter = currentRunCharacter
var longestRun = 0

if currentRunCharacter == nil {
return ""
}

sorted.forEach({(let char: Character) -> () in
if char == currentRunCharacter! {
currentRun += 1
} else {
currentRunCharacter = char
currentRun = 1
}
if longestRun < currentRun {
longestRun = currentRun
longestRunCharacter = currentRunCharacter
}
})
return String([Character](count: longestRun, repeatedValue: longestRunCharacter!))
}

// identity test
var zzzz = "zzzz"
assert(zzzz == longestRun(zzzz), "\(zzzz) should be the longest run of chars")

// book
// var book = "book"
// assert("oo" == longestRun(book), "longest run in \(book) is 'oo'")
var book = "book"
assert("oo" == longestRun(book), "longest run in \(book) is 'oo'")