Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain why more() returns always false in the record picker. #126

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

Carreau
Copy link
Contributor

@Carreau Carreau commented Aug 19, 2023

I think it looks like a mistake to always return false, while it is correct. This is dues to the fact that more() should really be called something like more_with_zero_count().

I think it looks like a mistake to always return false,
while it is correct. This is dues to the fact that `more()` should
really be called something like `more_with_zero_count()`.
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #126 (3b0724c) into main (d56b823) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Files Changed Coverage Δ
src/iterators/recorded.rs 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Copy link
Collaborator

@jonhoo jonhoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to add this, it's almost certainly going to be helpful to some poor soul (maybe even me) in the future!

@jonhoo jonhoo merged commit bdfad24 into HdrHistogram:main Aug 25, 2023
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants