Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding Hashable conformance to IterationValue #11

Merged
merged 3 commits into from
Mar 10, 2023

Conversation

heckj
Copy link
Contributor

@heckj heckj commented Mar 7, 2023

Description

Adds Hashable conformance to IterationValue. Resolves #4

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Minimal checklist:

  • I have performed a self-review of my own code
  • I have added DocC code-level documentation for any public interfaces exported by the package
  • I have added unit and/or integration tests that prove my fix is effective or that my feature works

@heckj heckj changed the title adding Hashable conformance to IterationValue feat: adding Hashable conformance to IterationValue Mar 7, 2023
@codecov
Copy link

codecov bot commented Mar 7, 2023

Codecov Report

Merging #11 (0e53eb5) into main (e9214c5) will increase coverage by 0.02%.
The diff coverage is 98.21%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #11      +/-   ##
==========================================
+ Coverage   98.10%   98.12%   +0.02%     
==========================================
  Files           4        4              
  Lines        1631     1649      +18     
==========================================
+ Hits         1600     1618      +18     
  Misses         31       31              
Impacted Files Coverage Δ
...ests/HistogramTests/HistogramDataAccessTests.swift 99.08% <96.20%> (+<0.01%) ⬆️
Sources/Histogram/Histogram.swift 96.09% <97.14%> (+0.02%) ⬆️
...ests/HistogramTests/HistogramAutosizingTests.swift 100.00% <100.00%> (ø)
Tests/HistogramTests/HistogramTests.swift 100.00% <100.00%> (ø)
Impacted Files Coverage Δ
...ests/HistogramTests/HistogramDataAccessTests.swift 99.08% <96.20%> (+<0.01%) ⬆️
Sources/Histogram/Histogram.swift 96.09% <97.14%> (+0.02%) ⬆️
...ests/HistogramTests/HistogramAutosizingTests.swift 100.00% <100.00%> (ø)
Tests/HistogramTests/HistogramTests.swift 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9214c5...0e53eb5. Read the comment docs.

Copy link
Collaborator

@dimlio dimlio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

@dimlio dimlio merged commit bc9fd1e into HdrHistogram:main Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Add an implementation of the Recorder pattern
2 participants