Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: OPS-10968: use Yarn Berry vs. Yarn Classic #38

Merged
merged 1 commit into from Jan 2, 2024

Conversation

blimmer
Copy link
Contributor

@blimmer blimmer commented Jan 2, 2024

This PR updates us to use Yarn Berry vs. Yarn Classic.

@blimmer blimmer requested a review from a team as a code owner January 2, 2024 17:06
Copy link

sonarcloud bot commented Jan 2, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

- path: .yarn/plugins/@yarnpkg/plugin-workspace-tools.cjs
spec: "@yarnpkg/plugin-workspace-tools"
yarnPath: .yarn/releases/yarn-3.6.4.cjs
npmPublishAccess: public
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By default, scoped packages are private. Since this is public, we need to specify it explicitly here.

@@ -0,0 +1,9 @@
nodeLinker: node-modules
npmRegistryServer: https://registry.npmjs.org
plugins:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why these plugins?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are "core plugins" that people expect to be present from Yarn Classic. I'm including them on all Yarn Berry PRs for convenience. Yarn v4 (which was recently released) includes core plugins by default again.

@blimmer blimmer merged commit 166e0be into master Jan 2, 2024
3 checks passed
@blimmer blimmer deleted the OPS-10968_use_yarn_berry branch January 2, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants