Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] #311 - 검색 카테고리 엠티뷰 필터링 추가 #312

Merged
merged 2 commits into from
Sep 30, 2022
Merged

[Fix] #311 - 검색 카테고리 엠티뷰 필터링 추가 #312

merged 2 commits into from
Sep 30, 2022

Conversation

0inn
Copy link
Contributor

@0inn 0inn commented Sep 30, 2022

🔥 Pull requests

⛳️ 작업한 브랜치

👷 작업한 내용

검색 카테고리 엠티뷰 필터링 추가했습니다.

🚨 참고 사항

기존에 자동검색어 list의 개수가 0일 때 emptyView를 호출하는 방식으로 구현했었는데
음식 카테고리가 추가되면서 카테고리가 있으면서 검색 결과가 없는 경우에 emptyView가 뜨지 않는 이슈가 있었습니다.
그래서 필터링을 통해 이슈 해결했습니다.

if searchList.filter({ $0.isCategory == false }).count == 0 && !fromRecent {
            searchEmptyView.isHidden = false
}

📸 스크린샷

문제 상황 (ex. "덮" 검색 시)

수정 전 후
검색 결과

📟 관련 이슈

@0inn 0inn added Fix 오류 해결, 코드 수정 ☁️Jenny labels Sep 30, 2022
@0inn 0inn self-assigned this Sep 30, 2022
@0inn 0inn added this to In progress in HeathFoodMe via automation Sep 30, 2022
L-j-h-c
L-j-h-c approved these changes Sep 30, 2022
View reviewed changes
Copy link
Member

@L-j-h-c L-j-h-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

멋져욜!!

@0inn 0inn merged commit e21b570 into Health-Food-Me:develop Sep 30, 2022
HeathFoodMe automation moved this from In progress to Done Sep 30, 2022
@0inn 0inn deleted the feature/#311 branch September 30, 2022 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@L-j-h-c L-j-h-c L-j-h-c approved these changes

Assignees

@0inn 0inn

Labels
Fix 오류 해결, 코드 수정 ☁️Jenny
Projects
HeathFoodMe
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Fix] 검색 카테고리 엠티뷰 필터링 추가
2 participants
@0inn @L-j-h-c