[Design] #12 - 햄버거바 UI 구현 #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. 배경색 지정 2. 레이아웃 지정
배경만 애니메이션 적용 햄버거바의 요소에는 적용되지 않음
제스처 추가 touchesBegan 오류 해결
사용하지 않는 이미지 삭제
L-j-h-c
reviewed
Jul 12, 2022
| // | ||
|
|
||
| import UIKit | ||
| import SnapKit |
Comment on lines
32
to
39
| struct HamburgerBar { | ||
| static let logout = "로그아웃" | ||
| static let setting = "설정" | ||
| static let reposrtCorrection = "수정사항 제보하기" | ||
| static let reportStore = "가게 제보하기" | ||
| static let myReview = "내가 쓴 리뷰" | ||
| static let scrapList = "스크랩한 식당" | ||
| } |
There was a problem hiding this comment.
p4;
이친구 Map 안에 들어갈거니까 struct Map으로 한번 더 감싸주세요~
| private let screenWidth = UIScreen.main.bounds.width | ||
| private lazy var hamburgerBarButton = UIButton() | ||
| private var menuButtons: [UIButton] = [] | ||
| private let buttonTitles: [String] = ["스크랩한 식당", "내가 쓴 리뷰", "가게 제보하기", |
There was a problem hiding this comment.
예네도 StringLiterals에 빼줄 수 있을 것 같아요~
|
|
||
| override func viewDidLoad() { | ||
| super.viewDidLoad() | ||
|
|
There was a problem hiding this comment.
p4;
요부분 공백 지워주세요~~ 슬랙에 태그해드렸습니당!
Comment on lines
107
to
112
| override func touchesBegan(_ touches: Set<UITouch>, with event: UIEvent?) { | ||
| if let touch = touches.first, | ||
| touch.view != hamburgerBarView { | ||
| dismissHamburgerBarWithAnimation() | ||
| } | ||
| } |
Comment on lines
127
to
139
| for buttonIndex in 0...3 { | ||
| let button = UIButton() | ||
| button.setTitle(buttonTitles[buttonIndex], for: .normal) | ||
| button.setTitleColor(.helfmeBlack, for: .normal) | ||
| button.titleLabel?.font = UIFont.PretendardRegular(size: 16) | ||
| menuButtons.append(button) | ||
|
|
||
| if buttonIndex < 2 { | ||
| storeButtonStackView.addArrangedSubviews(menuButtons[buttonIndex]) | ||
| } else { | ||
| reportButtonStackView.addArrangedSubviews(menuButtons[buttonIndex]) | ||
| } | ||
| } |
There was a problem hiding this comment.
덕분에 중복코드 많이 줄였습니다,, 최고선배🥺
Comment on lines
143
to
147
| for _ in 0...2 { | ||
| let view = UIView() | ||
| view.backgroundColor = .helfmeLineGray | ||
| dividingLineViews.append(view) | ||
| } |
There was a problem hiding this comment.
p5;
요것도 원한다면 UIView 배열 선언할 때 클로저 안에서 해줄 수 있어용~
There was a problem hiding this comment.
private var dividingLineViews: [UIView] = {
//code
}()
이런식으로 작성하는건가요?! 만약 맞다면 dividingLineViews.append(view)는 어디서 해주는건지 잘 모르겠습니다😞
Comment on lines
224
to
227
| let hamburgerViewWidth = screenWidth * 0.71 | ||
| self.hamburgerBarView.snp.updateConstraints { make in | ||
| make.trailing.equalToSuperview().inset(screenWidth - hamburgerViewWidth) | ||
| } |
Comment on lines
264
to
281
| if hambergurBarViewTranslation.x > -80 { | ||
| let containerViewWidth = screenWidth * 0.71 | ||
| self.hamburgerBarView.snp.updateConstraints { make in | ||
| make.trailing.equalToSuperview().inset(screenWidth - containerViewWidth) | ||
| } | ||
|
|
||
| UIView.animate(withDuration: 0.4) { | ||
| self.view.backgroundColor = .helfmeBlack.withAlphaComponent(0.4) | ||
| self.hamburgerBarView.transform = CGAffineTransform(translationX: 0, y: 0) | ||
| self.view.layoutIfNeeded() | ||
| } | ||
|
|
||
| UIView.animate(withDuration: 0.1) { | ||
| self.hamburgerBarView.transform = .identity | ||
| } | ||
| } else { | ||
| dismissHamburgerBarWithAnimation() | ||
| } |
i-colours-u
approved these changes
Jul 12, 2022
|
|
||
| class ButtonVC: UIViewController { | ||
| override func viewDidLoad() { | ||
| super.viewDidLoad() |
Comment on lines
+16
to
+17
| var hambergurBarViewTranslation = CGPoint(x: 0, y: 0) | ||
| var hambergurBarViewVelocity = CGPoint(x: 0, y: 0) |
There was a problem hiding this comment.
이거 사용하지 않은 프로퍼티라면 날려주세요 !! p3;
There was a problem hiding this comment.
moveHamburgerBarWithGesture()에서 위치와 방향 잡을 때 사용하는 변수라 살려두겠슴다!
| private let screenWidth = UIScreen.main.bounds.width | ||
| private lazy var hamburgerBarButton = UIButton() | ||
| private var menuButtons: [UIButton] = [] | ||
| private let buttonTitles: [String] = ["스크랩한 식당", "내가 쓴 리뷰", "가게 제보하기", |
There was a problem hiding this comment.
나중에 I18N 스트링 적어두고 따로 빼주시면 좋을것 같아요!! p4;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔥 Pull requests
⛳️ 작업한 브랜치
👷 작업한 내용
🚨 참고 사항
📸 스크린샷
📟 관련 이슈