Fix fetching Concepts to be conditional #775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dev-Akashili
previously approved these changes
Jul 3, 2024
AndrewThien
approved these changes
Jul 3, 2024
Dev-Akashili
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes fetching Scan Report Concepts at Scan Reports Fields/Values page level, to be conditional based on if fields/values exist.
The issue was that if no fields/values existed, Concepts would still be fetched without the filtering, resulting in long running queries. A few of these in succession (for example, through revalidation) could slow the API down to a halt.
Additionally adding pagination to the endpoints used, and therefore updating the client to fetch all pages where necessary.
We will probably now upgrade any unpaginated endpoint to a
v2with pagination, this is a general concern across every endpoint.Additionally adds a Forbidden layout - if the user does not have permission to see the Scan Report.
Related #761
Checks
Important: please complete these before merging.
changelog.md, including migration instructions if any.