Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding dataset bug fix #777

Merged
merged 4 commits into from
Jul 3, 2024
Merged

Adding dataset bug fix #777

merged 4 commits into from
Jul 3, 2024

Conversation

AndrewThien
Copy link
Contributor

Changes

This PR adds a fix for the Adding Dataset.
When modifying the API for Updating the Dataset details, changes there accidentally made the API for creating a new Data set break. This PR fixed it now by adding a V2 Serialiser. This will be combined in the future with the Adding New Dataset API, potentially.

Checks

Important: please complete these before merging.

  • Run migrations, if any.
  • Update changelog.md, including migration instructions if any.
  • Run unit tests.

Copy link

github-actions bot commented Jul 1, 2024

Tests Skipped Failures Errors Time
25 1 💤 1 ❌ 0 🔥 4.118s ⏱️

@AndrewThien AndrewThien marked this pull request as ready for review July 1, 2024 15:21
app/api/api/views.py Outdated Show resolved Hide resolved
Jivanam
Jivanam previously approved these changes Jul 2, 2024
@AndyRae AndyRae merged commit 9e5b7b6 into master Jul 3, 2024
14 checks passed
@AndyRae AndyRae deleted the bug/fix-adding-dataset branch July 3, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants