Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate out menu from split button #676

Closed
joeskeen opened this issue Jan 11, 2019 · 2 comments · Fixed by #1013
Closed

Separate out menu from split button #676

joeskeen opened this issue Jan 11, 2019 · 2 comments · Fixed by #1013
Assignees
@andrew-frueh
Labels
enhancement new minor version number to the library new component released

Comments

@joeskeen
Copy link
Contributor

joeskeen commented Jan 11, 2019 •
edited
Loading

Describe the problem this feature request is solving
The recent changes to the split button allowing a drop down menu are awesome! Only issue is, this type of menu is useful outside of the context of the split button, particularly with icon buttons.

Describe the solution you'd like
Separating this out into its own thing that is used by both the split button and any other buttons would make it much more useful.

Describe alternatives you've considered
See #567

If any, which components will have to change, and how

  • Split button
  • add new Menu component
@joeskeen joeskeen added the enhancement new minor version number to the library label Jan 16, 2019
@joeskeen joeskeen added this to Needs triage in Cashmere Component Backlog Aug 27, 2019
@andrew-frueh
Copy link
Collaborator

Probably will roll this in to #961 - because if we're updating our standard for the help menu, it should probably leverage the new standard menu component.

@andrew-frueh andrew-frueh self-assigned this Sep 25, 2019
@andrew-frueh andrew-frueh moved this from Awaiting triage to Medium priority in Cashmere Component Backlog Sep 25, 2019
andrew-frueh added a commit to andrew-frueh/Fabric.Cashmere that referenced this issue Sep 28, 2019
@andrew-frueh
refactor(popover): menu directives
d28fc99 
moves split button menu directives to popover and updates examples

closes HealthCatalyst#676
@andrew-frueh andrew-frueh mentioned this issue Sep 28, 2019
Merged
Cashmere Component Backlog automation moved this from Medium priority to Completed Oct 7, 2019
@benjanderson
Copy link
Contributor

🎉 This issue has been resolved in version 6.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrew-frueh andrew-frueh

Labels
enhancement new minor version number to the library new component released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

hcMenu Directives andrew-frueh/Fabric.Cashmere
3 participants
@benjanderson @joeskeen @andrew-frueh