fix(toasts): closing multiple toasts #1019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ensures cleanup functions are called on close with multiple toasts closes HealthCatalyst#1018
|
I'm pretty sure that takeUntil was introduced to fix the IE bug... I'll take a look at it and make sure that this doesn't cause a regression. |
|
Interesting. I tested on IE11 with BrowserStack and the fix looks like it's working. Let me know if you see anything different. |
corykon
approved these changes
Oct 8, 2019
|
Thanks for testing that @corykon |
|
🎉 This PR is included in version 6.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures cleanup functions are called on close with multiple toasts. The
takeUntilpipe was preventing the cleanup functions from being called more than once when multiple toasts were open.@joeskeen can you verify there aren't any unintended consequences from removing that pipe? I'm not entirely sure why it was there in the first place, it may have been an artifact of an earlier version.
closes #1018