Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(bit): remove bit #1868

Merged
merged 1 commit into from May 17, 2022
Merged

build(bit): remove bit #1868

merged 1 commit into from May 17, 2022

Conversation

aaronbrethorst
Copy link
Collaborator

BREAKING CHANGE: apps previously using the ChangeCasePipe should now use the change-case npm package
directly

re #1750

BREAKING CHANGE: apps previously using the ChangeCasePipe should now use the change-case npm package
directly

re #1750
Copy link
Collaborator

@andrew-frueh andrew-frueh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incredible work @aaronbrethorst! Thank you thank you thank you!

@aaronbrethorst
Copy link
Collaborator Author

I'm going to hold this PR open a little longer. @corykon noticed a couple small nits that should get fixed in this before it lands. Cory - what's your preferred way to get those changes added? Shall I merge and have you do a quick follow-up fix, or would you prefer something else?

@corykon
Copy link
Collaborator

corykon commented May 17, 2022

@aaronbrethorst I'd love to submit those little tweaks to this PR, hoping to push that in today. If I don't get there though... go ahead and merge!

@corykon
Copy link
Collaborator

corykon commented May 17, 2022

I'm still struggling to get this to build and run... just tried deleting and recloning the repo. have you tried running it @andrew-frueh ? I'd love to be able to confirm if its a Windows OS thing.

@andrew-frueh
Copy link
Collaborator

I haven't yet @corykon - I'll try that now

@corykon corykon merged commit 921d170 into HealthCatalyst:dev May 17, 2022
@aaronbrethorst aaronbrethorst deleted the ab/rm-bit branch May 17, 2022 22:16
@health-catalyst
Copy link
Contributor

🎉 This PR is included in version 13.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants