Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: frontend continuous integration workflow addition #253

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Josecespedesant
Copy link

This pull request is related to Workflow for App Panel build generation #214

Some queries I'd like to discuss about the workflow in order to make any change prior to merge:

  1. It currently has commented lines 5 and 6, and also 12 and 13.

Is this workflow meant to run in any branch push/pull request? just main, or any branch except main? (Or any other condition in particular?)

#    branches:
#      - main
  1. Regarding

The workflow should generate a build with a unique identifier or timestamp.

The current timestamp is represented as 20240609T065947 with format (%Y%m%dT%H%M%S), is this accepted or should I change it to another formatting?

  1. Last but not least, I have lines 24, 25, 29, 30, 63, and 64 commented out as they are part of my effort to make this stefanzweifel/git-auto-commit-action@v5 action work, it is for

detect changed files during a Workflow run and to commit and push them back to the GitHub repository.

I'm currently getting this error:

| git@github.com: Permission denied (publickey).
| fatal: Could not read from remote repository.
|
| Please make sure you have the correct access rights
| and the repository exists.
| Error: Invalid status code: 128

I'm not entirely sure if this is something we want and I'm not understanding the request of

The generated build should be pushed to the assets folder within the repository.

Any help/comments about this PR is welcomed, thank you!

@shahharsh176
Copy link
Contributor

@Josecespedesant

Apologies for the delay in my response.

Answers to your questions:

  1. This workflow is meant to run upon the creation or update of a PR to the main branch.
  2. The build filename can be in this format: build.<timestamp>.min.js
  3. Once the build is generated, it should be pushed to the branch from which the PR was created.

python-version: ${{ matrix.python-version }}

- name: Execute setup script for configuration, asumes frontend as project directory
run: python setup_project.py --project_dir 'frontend'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't need to create the new project here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants