Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GET basic auth from stac-fastapi.core #19

Merged
merged 5 commits into from
May 4, 2024
Merged

GET basic auth from stac-fastapi.core #19

merged 5 commits into from
May 4, 2024

Conversation

jonhealy1
Copy link
Contributor

@jonhealy1 jonhealy1 commented May 4, 2024

Related Issue(s):

Description:

PR Checklist:

  • Code is formatted and linted (run pre-commit run --all-files)
  • Tests pass (run make test)
  • Documentation has been updated to reflect changes, if applicable
  • Changes are added to the changelog

@pedro-cf pedro-cf self-requested a review May 4, 2024 11:26
@pedro-cf
Copy link
Collaborator

pedro-cf commented May 4, 2024

Greetings @jonhealy1 I see you are still working so I'll wait a bit to add some suggestions :)

@jonhealy1
Copy link
Contributor Author

Hi @pedro-cf :) Go ahead now.

@jonhealy1
Copy link
Contributor Author

A couple of the changes that belong here in this pr I pushed directly to main by mistake

@pedro-cf
Copy link
Collaborator

pedro-cf commented May 4, 2024

Hi @pedro-cf :) Go ahead now.

  • Revert the github workflow changes so we only have 1 testing step. Remove the step "Run test suite against Mongo w/ Basic Auth"
  • Bring the improved basic_auth tests from sfeos to here aswell as the conftest.py changes. These conftest.py changes bring improved fixtures that include the environment variables needed for the basic_tests and therefore not needing an extra step in the github workflow

@jonhealy1
Copy link
Contributor Author

Sounds really good. Do you want to add the changes to this pr?

@pedro-cf
Copy link
Collaborator

pedro-cf commented May 4, 2024

Sounds really good. Do you want to add the changes to this pr?

ok sure

Copy link
Collaborator

@pedro-cf pedro-cf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good.

@pedro-cf
Copy link
Collaborator

pedro-cf commented May 4, 2024

You can merge @jonhealy1 I believe.

@jonhealy1
Copy link
Contributor Author

Nice work thank you!

@jonhealy1 jonhealy1 merged commit 226c95e into main May 4, 2024
4 checks passed
@jonhealy1 jonhealy1 deleted the move-basic-auth branch May 4, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants