Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement mana crystals: graphics, color/opacity transitions, overload #61

Closed
wants to merge 1 commit into from

Conversation

azeier
Copy link
Member

@azeier azeier commented Mar 13, 2016

Implements #22, #32 and #33.
Also fixes temp resources (coin, innervate) not being reflected.

If we don't want to use the crystal graphics I do also have the css hexagons as posted in discord, I do believe however, that it looks a lot better with the graphics.

mana2

@beheh
Copy link
Member

beheh commented Mar 26, 2016

Looks good! The only thing is, I'd like to get rid of the endless getters in Entity. They mainly stem from a time where we didn't have enums and I was to lazy to have the numbers everywhere. Eventually I'd like to remove all but the very common ones (like health, controller...). Could you please remove the getters you used here and just directly do getTag(GameTag.X)?

Also fixes temp resources (coin, innervate) not being reflected
@azeier
Copy link
Member Author

azeier commented Mar 26, 2016

:shipit:

@beheh
Copy link
Member

beheh commented Mar 26, 2016

Landed as 423eb1f, good job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants