Fix off-by-one error for 2019.4 bundles #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, great fix. It solved the bug I was encountering. Now if only it could be merged... |
|
Hi there @stevenvergenz, thanks for your PR! All contributions to HearthSim require a signed CLA. I've sent you an invite to the repository, please follow the instructions there. If you've already signed the CLA, please let us know. Once that's done and the CLA has been merged, we'll try to get this merged here as soon as possible. |
beheh
approved these changes
Aug 12, 2020
|
Great, thank you! |
drojf
added a commit
to drojf/UnityPack
that referenced
this pull request
Jan 25, 2024
- When option is enabled, reverts HearthSim#101
drojf
added a commit
to 07th-mod/ui-editing-scripts
that referenced
this pull request
Jan 25, 2024
- I added a 'legacy mode' flag to revert HearthSim/UnityPack#101 as it caused problems on Rei - I tested the new setup (using custom unitypack) vs old one, and the output .asset files were bit-for-bit identical
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each type tree in Unity 2019.4 (format 21) has an extra 4 bytes at the end compared to Unity 2019.1 (format 19), whose purpose is unknown. This PR consumes these 4 bytes so they don't cascade into bad offsets for the rest of the parse.