fix: windows compatible regex and filename #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hebilicious
changed the title
Hebilicious
requested changes
Nov 7, 2023
There was a problem hiding this comment.
Hi Evan,
Thanks for reporting this issue. I have not tried this module on windows, and that's unfortunate that it doesn't work.
Regarding the virtual:loader-types.d.ts you'll need to modify the tsconfig here https://github.com/Hebilicious/form-actions-nuxt/blob/main/tsconfig.json if you rename the file. Then everything should work.
…according to Hebilicious comment
|
Hi Hebilicious, I have modified the specified file according to your comment. Hope it will pass now. Regards |
Hebilicious
reviewed
Nov 9, 2023
Hebilicious
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
📚 Description
Resolves #86
📝 Checklist