This repository has been archived by the owner on Oct 30, 2023. It is now read-only.
Feat / Refactor perils and add tab navigation #659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gustaveen
force-pushed
the
GRW-1047/refactor-perils-add-tabs
branch
3 times, most recently
from
ce075d2
to
4950000
Compare
simonauner
previously approved these changes
May 4, 2022
No that's great! It was just me who missed it so thanks for pointing it out 🙏 |
simonauner
previously approved these changes
May 5, 2022
simonauner
approved these changes
May 5, 2022
simonauner
previously approved these changes
May 6, 2022
robinandeer
previously approved these changes
May 6, 2022
| import { LAPTOP_BP_UP } from '../blockHelpers' | ||
| import { UnderlineComponent, UNDERLINE_HEIGHT } from './Underline' | ||
|
|
||
| const TabContainer = styled.button<{ selected?: boolean }>` |
There was a problem hiding this comment.
Do we override the focus state globally? Don't remember, otherwise would be nice to add one here :)
There was a problem hiding this comment.
You mean adding a focus state for the tabs? @robinandeer
There was a problem hiding this comment.
Yeah for these buttons -- but maybe it's covered in some other way?
We couldn't add a more recent version without editing the webpack settings and we had to add tslib
gustaveen
force-pushed
the
GRW-1047/refactor-perils-add-tabs
branch
from
067f832
to
07c5228
Compare
|
Thanks haha but you did all the heavy lifting for this one :D A tricky thing indeed with the line animation! 🙏 @robinandeer |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add tab navigation for Perils instead of current dropdown navigation.
I moved over the Tabs component from web-onboarding.
4.1.17(issue described here: [BUG] 5.0 Failed to compile with create-react-app framer/motion#1307) and that's the same version we use inonboarding. That did cause another issue as well wheretslibcomplainedWARNING in ./node_modules/popmotion/dist/es/utils/mix-complex.js 22:15-28 "export '__spreadArray' was not found in 'tslib'so we had to add that as a dependency as well. More on that issue here:[BUG] framer-motion breaks in tslib version 2.2.0 framer/motion#1123
Perilscomponent to simply accept a collection of perilsPerilsCollection. I therefore renamed some of the components to make more sense.usePerilsto fetch multiple peril typesWhy?
Consistent UI with Perils in onboarding
Screenshots / recordings
Storybook
Screen.Recording.2022-05-03.at.15.44.06.mov
Storyblok
Screen.Recording.2022-05-04.at.10.27.41.mov