[GEN-400] Update to Insurely Blocks API #2140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
robinandeer
force-pushed
the
update/insurely-blocks
branch
from
dac3bf1
to
b5f3650
Compare
robinandeer
force-pushed
the
update/insurely-blocks
branch
from
b5f3650
to
bba9001
Compare
robinandeer
force-pushed
the
update/insurely-blocks
branch
from
bba9001
to
c5820b4
Compare
robinandeer
force-pushed
the
update/insurely-blocks
branch
from
c5820b4
to
ef8aada
Compare
robinandeer
force-pushed
the
update/insurely-blocks
branch
from
ef8aada
to
88d3f2e
Compare
robinandeer
force-pushed
the
update/insurely-blocks
branch
from
88d3f2e
to
adc52ec
Compare
robinandeer
force-pushed
the
update/insurely-blocks
branch
from
adc52ec
to
b0a022d
Compare
robinandeer
force-pushed
the
update/insurely-blocks
branch
from
b0a022d
to
d6a29ad
Compare
robinandeer
force-pushed
the
update/insurely-blocks
branch
from
d6a29ad
to
3923673
Compare
robinandeer
force-pushed
the
update/insurely-blocks
branch
from
71195dd
to
c61eeaa
Compare
robinandeer
force-pushed
the
update/insurely-blocks
branch
from
c61eeaa
to
81f0d09
Compare
robinandeer
force-pushed
the
update/insurely-blocks
branch
from
81f0d09
to
0320837
Compare
robinandeer
force-pushed
the
update/insurely-blocks
branch
from
0320837
to
13a3df0
Compare
robinandeer
force-pushed
the
update/insurely-blocks
branch
2 times, most recently
from
11dafa3
to
61c6e26
Compare
robinandeer
changed the title
alebedev
reviewed
Jun 7, 2023
| @@ -88,7 +92,7 @@ export const CurrentInsuranceField = (props: Props) => { | |||
| const [updateDataCollectionId] = usePriceIntentInsurelyUpdateMutation({ | |||
| onCompleted({ priceIntentInsurelyUpdate }) { | |||
| datadogLogs.logger.info('Updated Insurely data collection ID', { | |||
| priceIntentId, | |||
| priceIntentId: props.priceIntentId, | |||
There was a problem hiding this comment.
Nit: 4 usages of props.priceIntentId, moving it to local variable will shorten the code
alebedev
approved these changes
Jun 7, 2023
| | { type: 'SUCCESS'; externalInsurer: ExternalInsurer } | ||
| | { type: 'CONFIRMED'; externalInsurer: ExternalInsurer } | ||
|
|
||
| export const CurrentInsuranceField = (props: Props) => { | ||
| const { label, productName, priceIntentId, insurelyClientId, externalInsurer } = props | ||
| const { t } = useTranslation('purchase-form') | ||
| const { shopSession } = useShopSession() | ||
| const [state, setState] = useState<State>({ type: 'IDLE' }) | ||
|
|
||
| const compare = useCallback( |
There was a problem hiding this comment.
This state + useCallback API looks a bit complex. Can it be improved?
Some ideas to try
- useReducer / jotai
- Separate concepts of Insurely and CurrentInsurance and move Insurely state into its own thing
This is probably for another PR
There was a problem hiding this comment.
Agreed! We will need to do this before we can support Car with Insurely so let's dig into it then
robinandeer
force-pushed
the
update/insurely-blocks
branch
from
61c6e26
to
4638a5e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Use the new "Blocks API" from Insurely.
Get
insurelyConfigNameon PriceIntent.New environment variable for global Insurely customer ID
Justify why they are needed
Insurely is discontinuing the old iFrame solution so only this new one will receive updates!
Jira issue(s): []
Checklist before requesting a review