GRW-1510 / improvements to middleware routing

[KarnellSchultz]

Describe your changes

• Add logging on the root middleware (this is for our testing now, could be removed later)

• Changed the routing to use lowercase routing for pretty urls 🍒

  • the url preview url is going from .../sv-SE/ to .../sv-se/
  • 

• Tighten up the types being used by for localisation

  • 

Justify why they are needed

• Creates nicer urls which are lowercase which is inline with how we'd like to show our urls.
• The types changes prevent users of some of the localisation functions so that users do not use the funcs in a way that would be unexpected.

Jira issue(s): GRW-1510

Checklist before requesting a review

• I have performed a self-review of my code

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
racoon-store	✅ Ready (Inspect)	Visit Preview	Sep 22, 2022 at 2:13PM (UTC)

1 Ignored Deployment

Name	Status	Preview	Updated
racoon	⬜️ Ignored (Inspect)		Sep 22, 2022 at 2:13PM (UTC)

[simonauner]

Yazzzz! More types! Type it harder!

[simonauner]

I'm no TS pro, but could this be or will TS complain?

Suggested change

	export const routingLocale = (locale: LocaleValues) => locale.toLowerCase() as RoutingLocale
	export const routingLocale = (locale: LocaleValues):RoutingLocale => locale.toLowerCase()

[KarnellSchultz]

Yeahhh feels a lil dirty to be casting that type but TS complains without it since toLowerCase() only returns a string. So going in we have out clean and specific type. but coming out we only have a string :feelsbad:

[alebedev]

Can we worker around with conversion function that return proper type
asRoutingLocale = (locale: LocaleValues): RoutingLocale => { return locale.toLowerCase() as RoutingLocale }

But only ways without assertion that I know are

• to have explicit mapping or explicit switch statement
• to check toLowerCase result agains all possible keys in RoutingLocale

[robinandeer]

Looks good! Something to think about for the future is that we might want to redirect any URL that doesn't contain a locale but let's start like this :)

[alebedev]

Nice! Some nit comments

[alebedev]

Can we worker around with conversion function that return proper type
asRoutingLocale = (locale: LocaleValues): RoutingLocale => { return locale.toLowerCase() as RoutingLocale }

But only ways without assertion that I know are

• to have explicit mapping or explicit switch statement
• to check toLowerCase result agains all possible keys in RoutingLocale