This repository has been archived by the owner on Aug 23, 2023. It is now read-only.
Add landing page before token exchange #1255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
alebedev
approved these changes
May 24, 2023
| @@ -114,7 +114,7 @@ router.post( | |||
| ) | |||
|
|
|||
| router.get( | |||
There was a problem hiding this comment.
Should we redirect from old URL to prevent links from becoming 404?
There was a problem hiding this comment.
hmm not sure what you mean, the "old URL" is now the landing page
There was a problem hiding this comment.
When we deploy it, would existing links from Hope or hedvig-com break?
There was a problem hiding this comment.
I can't see how anything would break 🤔
From HOPE users will just land on this page instead of being redirected automatically.
It doesn't implicate hedvig-com
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add a landing page before we do the token exchange.
Why?
There has been issues with links that become invalid after being visited multiple times.
With this solution we can send out the link to the landing page, and the user can then click on the button to get to the token exchange.
Ticket(s): []