Skip to content

Commit

Permalink
Issue #1722: add missing translation strings to master file
Browse files Browse the repository at this point in the history
  • Loading branch information
ansgarbecker committed Dec 11, 2022
1 parent d02fdb8 commit 8fc6dba
Show file tree
Hide file tree
Showing 3 changed files with 33 additions and 1 deletion.
29 changes: 28 additions & 1 deletion out/locale/en/LC_MESSAGES/default.po
Expand Up @@ -7,7 +7,7 @@ msgid ""
msgstr ""
"Project-Id-Version: HeidiSQL\n"
"POT-Creation-Date: 2012-11-05 21:40\n"
"PO-Revision-Date: 2022-12-06 19:09+0100\n"
"PO-Revision-Date: 2022-12-11 12:51+0100\n"
"Last-Translator: Ansgar Becker <anse@heidisql.com>\n"
"Language-Team: English (http://www.transifex.com/projects/p/heidisql/language/en/)\n"
"Language: en\n"
Expand Down Expand Up @@ -1732,6 +1732,9 @@ msgstr "Cut|Cuts the selection and puts it on the Clipboard"
msgid "&Undo"
msgstr "&Undo"

msgid "Undo|Revert last modification"
msgstr "Undo|Revert last modification"

This comment has been minimized.

Copy link
@mlocati

mlocati Dec 16, 2022

Should we translate "Undo" and "Revert last modification" as two different strings?

This comment has been minimized.

Copy link
@ansgarbecker

ansgarbecker Dec 17, 2022

Author Collaborator

No, as one string, separated with pipe. This is how Delphi's "Hint" property expects them: "short caption|longer hint"

This comment has been minimized.

Copy link
@mlocati

mlocati Dec 17, 2022

That's what I meant: it's one string that is composed by two different stuffs to be translated independently (Undo and Revert...

What about adding a comment for translators (that is, a line in the .po starting with #)

This comment has been minimized.

Copy link
@ansgarbecker

ansgarbecker Dec 17, 2022

Author Collaborator

Yes, that makes sense. Just did that. Will add one for the other 11 joined hints as well.

This comment has been minimized.

Copy link
@mlocati

mlocati Dec 17, 2022

Super fast!

This comment has been minimized.

Copy link
@ansgarbecker

ansgarbecker Dec 23, 2022

Author Collaborator

I cannot see these # abc comments in the Transifex web editor. Is that normal? Only developer notes #. abc and occurrences #: abc are displayed.

This comment has been minimized.

Copy link
@mlocati

mlocati Dec 23, 2022

Indeed... It seems that Transifex doesn't show # comments... what about switching to #. ?

This comment has been minimized.

Copy link
@ansgarbecker

ansgarbecker Dec 23, 2022

Author Collaborator

The documentation says the #. syntax is meant for extracted comments (not for developer notes like Transifex displays them). So yes, why not.

This comment has been minimized.

Copy link
@mlocati

mlocati Dec 23, 2022

Yep, #. seems more appropriate accordigngly to the docs:

  • # is for comments created and maintained by the translators
  • #. is for comments given by the programmer, directed at the translators

#. MainForm..ActionList1..actAboutBox..Caption
#: main.dfm:1931

This comment has been minimized.

Copy link
@B52parg

B52parg Dec 18, 2022

tanks

msgid "About..."
Expand Down Expand Up @@ -6752,3 +6755,27 @@ msgstr "Auto-disabling wordwrap for large text"

msgid "%d tab(s) took longer than expected to restore. Closing and reopening these should fix that: %s"
msgstr "%d tab(s) took longer than expected to restore. Closing and reopening these should fix that: %s"

msgid "Library:"
msgstr "Library:"

msgid "Move line up"
msgstr "Move line up"

msgid "Move line down"
msgstr "Move line down"

msgid "New query tab in background"
msgstr "New query tab in background"

msgid "Follow foreign key"
msgstr "Follow foreign key"

msgid "Follow foreign key to the linked table"
msgstr "Follow foreign key to the linked table"

msgid "Copy with tabs to spaces"
msgstr "Copy with tabs to spaces"

msgid "Connection properties"
msgstr "Connection properties"
4 changes: 4 additions & 0 deletions source/main.dfm
Expand Up @@ -2079,6 +2079,9 @@ object MainForm: TMainForm
object MainMenuEdit: TMenuItem
Caption = 'Edit'
Hint = 'Edit commands'
object Undo1: TMenuItem
Action = actUndo
end
object CopyItem: TMenuItem
Action = actCopy
end
Expand Down Expand Up @@ -2428,6 +2431,7 @@ object MainForm: TMainForm
Category = 'Various'
Caption = '&Undo'
Enabled = False
Hint = 'Undo|Revert last modification'
ImageIndex = 40
ImageName = 'icons8-undo'
ShortCut = 32776
Expand Down
1 change: 1 addition & 0 deletions source/main.pas
Expand Up @@ -778,6 +778,7 @@ TMainForm = class(TExtForm)
Movelineup1: TMenuItem;
menuToggleAll: TMenuItem;
menuCloseTabOnDblClick: TMenuItem;
Undo1: TMenuItem;
procedure actCreateDBObjectExecute(Sender: TObject);
procedure menuConnectionsPopup(Sender: TObject);
procedure actExitApplicationExecute(Sender: TObject);
Expand Down

0 comments on commit 8fc6dba

Please sign in to comment.