Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot create VIEW on MSSQL #39

Closed
ionred opened this issue Dec 11, 2017 · 8 comments
Labels
Milestone

Comments

@ionred
Copy link

@ionred ionred commented Dec 11, 2017

Current behavior

When creating a view on MS SQL 11.0 DB, algorithm is set to undefined, but instead of ignoring algorithm in the create statement, it still leaves "ALGORITHM = UNDEFINED" at the beginning of the create. The entire Alg section should be unavailable/grayed out as well for a MSSQL connection.

Failure information (for bugs)

/* SQL Error (343): Unknown object type 'ALGORITHM' used in a CREATE, DROP, or ALTER statement. */

Steps to reproduce

Please provide detailed steps for reproducing the issue.

  1. CREATE ALGORITHM = UNDEFINED VIEW "V_ZCUSTOM_AGTDATA" AS .......
  2. /* SQL Error (343): Unknown object type 'ALGORITHM' used in a CREATE, DROP, or ALTER statement.*/

Context

Please provide any relevant information about your setup. This is important in case the issue is not reproducible except for under certain conditions.

  • HeidiSQL version: 9.4
  • Database system + version: MS SQL 11
@ansgarbecker

This comment has been minimized.

Copy link
Collaborator

@ansgarbecker ansgarbecker commented Dec 12, 2017

The view editor in HeidiSQL does currently not care for other systems but MySQL/MariaDB. I guess the controls (definer, sql security, algorithm and check option) are not applicable to a view in MSSQL, or? Is there some good documentation on how to read and write views in MSSQL?

@ionred

This comment has been minimized.

Copy link
Author

@ionred ionred commented Dec 12, 2017

https://docs.microsoft.com/en-us/sql/t-sql/statements/create-view-transact-sql
is the most specific information I can find on create view.
There are "view attributes" that I can't speak for their necessity; but they sound like limited need items for implementation. The rest of the options in the create view screen can likely be dithered/disabled on MSSQL connections.

@ansgarbecker ansgarbecker changed the title Cannot create VIEW on MSSQL due to unsuported algorithm Cannot create VIEW on MSSQL Jan 2, 2018
@ghost

This comment has been minimized.

Copy link

@ghost ghost commented Mar 21, 2018

@ansgarbecker Similar issue with editing an existing view:

Hit "Save" and receive an error:

ALTER SQL SECURITY DEFINER VIEW "ExampleView" AS SELECT ...
/* SQL Error (343): Unknown object type 'SQL' used in a CREATE, DROP, or ALTER statement. */

Literally all we need for MS SQL is to ignore the header options so the command sent is simply ALTER VIEW ...
Like @ionred mentioned, the other MS SQL specific options are of limited need.

Server: MS SQL 2008 R2
Client: HeidiSQL 9.5.0. 5196

@magisch

This comment has been minimized.

Copy link

@magisch magisch commented Jan 14, 2019

@ansgarbecker Creating and Editing views in MSSQL is actually really simple and used to work in HeidiSQL before one of the updates (don't remember which exactly.) but the crux is that the algorhitm and definer/invoker parts don't work with mssql. Best would be if you could turn these off so the generated syntax would just be "CREATE VIEW [schema_name.]view_name AS " and "ALTER VIEW [schema_name.]view_name AS".

MSDN has some nice documentation about MSSQL views too: https://docs.microsoft.com/de-de/sql/t-sql/statements/create-view-transact-sql?view=sql-server-2017

An option like that would probably be compatible with all other dbms too, as create/alter view instructions are basic sql I think.

@ionred

This comment has been minimized.

Copy link
Author

@ionred ionred commented Oct 8, 2019

Hi @ansgarbecker , is there an update on this bug?

@ansgarbecker

This comment has been minimized.

Copy link
Collaborator

@ansgarbecker ansgarbecker commented Oct 8, 2019

Not yet, but if it's really just that I have to remove the mentioned clauses, I can try to get this done for the next release.

@ansgarbecker ansgarbecker added this to the v10.3 milestone Oct 8, 2019
@ionred

This comment has been minimized.

Copy link
Author

@ionred ionred commented Oct 8, 2019

@ansgarbecker

This comment has been minimized.

Copy link
Collaborator

@ansgarbecker ansgarbecker commented Dec 3, 2019

Long story short: should work with the next build :)

grafik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.