Simplify mkWeakIORefValue #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is equivalent to the old code, but without the need to check the version of base. This change was inspired by looking at the source code for System.Mem.Weak.mkWeak in base.
|
LGTM, thanks. I suppose the original code may have had an eye towards eventually attaching finalizers to some refs, but in the meantime this does clean some things up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is equivalent to the old code, but without the need to check the version of base.
This change was inspired by looking at the source code for System.Mem.Weak.mkWeak in base.
I will not be offended if you reject this PR. I recognize that there is always risk when changing code, and since this code does the same thing as before, it may not be worth merging.
I have tested this code on GHC 7.8, 7.10, and 8.0. The tests pass on each of those three versions.