Support building with GHC 9 #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All pqueue needed was a base upper bound, I've put up a PR over there: lspitzner/pqueue#40 |
|
@mitchellwrosen I think this looks good - shall we get this in? |
ocharles
approved these changes
Aug 24, 2021
|
@ocharles Sure, I suppose it doesn't hurt to merge even though we still can't actually build with GHC 9 without an override to pqueue's bound :) ... but there's a conflict. Let me take care of that. |
added 2 commits
August 24, 2021 12:45
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch puts parens around SCC annotations per the 9.0 migration guide: https://gitlab.haskell.org/ghc/ghc/-/wikis/migration/9.0#parsing-of-scc-pragmas-less-permissive
Now this codebase builds with GHC 9:
cabal build reactive-banana -w ghc-9.0.1 --allow-newer=pqueue:base