Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report error context in Diagnostic #26

Merged
merged 2 commits into from Nov 2, 2020
Merged

Report error context in Diagnostic #26

merged 2 commits into from Nov 2, 2020

Conversation

Hejsil
Copy link
Owner

@Hejsil Hejsil commented Oct 15, 2020

This is the work that will close #6. Right now the new Diagnostic struct only contains a Names struct that will either contain the param.names in cases where there was an error parsing a specific parameter, or the name of an argument in case the argument doesn't match any parameter. I'll need to also create a function on Diagnostic called report that will be the default way of reporting a parsing error to a stream.

@Hejsil Hejsil merged commit 093d298 into master Nov 2, 2020
Hejsil added a commit that referenced this pull request Nov 2, 2020
@Hejsil Hejsil deleted the diagnostics branch November 2, 2020 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proper error types
1 participant