Refactoring of PCMockup/CMake #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gobuhl
requested changes
Nov 18, 2018
There was a problem hiding this comment.
Tested on windows but build isn't successful.
Errors are the following:
- Error C2220 warning treated as error - no 'object' file generated podrenderer Line 16
- Error C2220 warning treated as error - no 'object' file generated podrenderer Line 16
- Error C2220 warning treated as error - no 'object' file generated podrenderer Line 16
- Error C2220 warning treated as error - no 'object' file generated podrenderer Line 9
- Error C2220 warning treated as error - no 'object' file generated podrenderer Line 16
- Error C2220 warning treated as error - no 'object' file generated pcmockup Line 16
- Error C2220 warning treated as error - no 'object' file generated pcmockup Line 16
- Error C2220 warning treated as error - no 'object' file generated pcmockup Line 16
- Error C2220 warning treated as error - no 'object' file generated pcmockup Line 16
|
This is not the spark but another coffin nail for MSVC, I guess this can wait until #47 |
Helco
force-pushed
the
refactoring_2018_11_18
branch
from
26ed80a
to
51a8263
Compare
|
@gobuhl Please re-review this pull request With clang already merged into master this PR should not only work, but I also thrown in the before-mentioned refactoring of debug rendering |
gobuhl
approved these changes
Nov 23, 2018
Helco
force-pushed
the
refactoring_2018_11_18
branch
from
d95fb4d
to
5a4c538
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes many of infrastructural annoyances and helps to prepare #39 and #29