Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PCMockup: Add WindowGrid #46

Merged
merged 3 commits into from
Nov 20, 2018
Merged

PCMockup: Add WindowGrid #46

merged 3 commits into from
Nov 20, 2018

Conversation

Helco
Copy link
Owner

@Helco Helco commented Nov 18, 2018 •
edited by gobuhl
Loading

Extracted out of #39 to simplify PR.

  • Tested on Linux
  • Tested on Windows

@Helco Helco self-assigned this Nov 18, 2018
@Helco Helco added this to In progress in Meistertask via automation Nov 18, 2018
@Helco Helco requested a review from gobuhl November 18, 2018 16:36
@Helco Helco moved this from In progress to Needs review in Meistertask Nov 18, 2018
gobuhl
gobuhl approved these changes Nov 19, 2018
View reviewed changes
Copy link
Collaborator

@gobuhl gobuhl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on Windows

@Helco Helco merged commit 36ec80a into master Nov 20, 2018
Meistertask automation moved this from Needs review to Done Nov 20, 2018
@Helco Helco deleted the windowgrid branch November 20, 2018 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gobuhl gobuhl gobuhl approved these changes

Assignees

@Helco Helco

Labels
None yet
Projects
Meistertask
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Helco @gobuhl