entrez module added #63
Conversation
candis/app/server/api/data.py
Outdated
| @@ -231,3 +232,13 @@ def delete(): | |||
|
|
|||
| return json_, code | |||
|
|
|||
| @app.route(CONFIG.App.Routes.API.Data.DOWNLOAD, methods = ['POST']) | |||
There was a problem hiding this comment.
POST is added as of now- will change it to GET, when download through GEO will be possible.
requirements.txt
Outdated
| @@ -95,5 +95,6 @@ urllib3==1.22 | |||
| wcwidth==0.1.7 | |||
| webencodings==0.5.1 | |||
| Werkzeug==0.14.1 | |||
| wget==3.2 | |||
There was a problem hiding this comment.
requests module have only a monkey patch for FTP servers, so had to resort to wget which works well, and also displays a progress bar while downloading a file from the server (in this case GEO FTP server).
There was a problem hiding this comment.
Using inbuilt ftplib instead now.
candis/data/entrez/api.py
Outdated
| self.name = assign_if_none(name, Client.NAME) | ||
|
|
||
| # TODO: Should we cache databases? | ||
| self.name = assign_if_none(name, 'candis')#Client.NAME) |
There was a problem hiding this comment.
what was with the Client parameter? @achillesrasquinha - #17
There was a problem hiding this comment.
Replaced 'candis', with 'CONFIG.NAME'.
candis/data/entrez/api.py
Outdated
| else: | ||
| raise TypeError('params should be a dictionary') | ||
|
|
||
|
|
||
| # TODO: Should we cache each response? | ||
| class API(object): | ||
| # TODO: Assign CONFIG.NAME to NAME |
There was a problem hiding this comment.
We need to add in config file, 'NAME' field, and then use it here ? @achillesrasquinha
candis/data/entrez/api.py
Outdated
|
|
||
| return params | ||
|
|
||
| def _create_redis_instance(self): | ||
| # TODO: to parse .env files, use python-dotenv or envparse? and for defaults use config file? |
There was a problem hiding this comment.
Which one do you suggest @achillesrasquinha
Add GEO Entrez esearch basic setup
|
@achillesrasquinha Merging this now ✨, have added the TODO list in the issue #53 which I will solve in the follow-up PRs. |
Explanation About What Code Achieves:
Solves 1,2,3 and 4 task of #53
@achillesrasquinha GIF for you to review, how this API going to work
TO DO: