feat: Add support for maximum assets per change output #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a new configuration option `MAX_ASSETS_PER_CHANGE_OUTPUT` to the `config.js` file. If the value is set, it limits the maximum number of assets per change output. The `Tx` class in `tx-builder.js` now checks this configuration and splits the change output into multiple outputs if the number of assets exceeds the limit.
|
This may help with #102 - probably will not 'solve' the issue however it will help when the users 'unfrack' their Wallets |
|
Thanks for this contribution Gavin! At first I thought it would be better to keep this out of the library and leave it up to the user to implement such functionality during tx building. But this addition is clean and only a few lines of code, and at some point in the future we can set MAX_ASSETS_PER_CHANGE_OUTPUT to a sane default so a typical Helios dev never has to think about this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new configuration option
MAX_ASSETS_PER_CHANGE_OUTPUTto theconfig.jsfile. If the value is set, it limits the maximum number of assets per change output. TheTxclass intx-builder.jsnow checks this configuration and splits the change output into multiple outputs if the number of assets exceeds the limit.