Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control Center Command Line option not working #755

Closed
3 of 5 tasks
BlueFinBima opened this issue Sep 13, 2023 · 3 comments
Closed
3 of 5 tasks

Control Center Command Line option not working #755

BlueFinBima opened this issue Sep 13, 2023 · 3 comments
Assignees
Labels
Delivered Code for this issue is in a generally available Helios Release enhancement New feature or request

Comments

@BlueFinBima
Copy link

BlueFinBima commented Sep 13, 2023


Describe the Helios Issue

Specifying a profile as an argument for Control Center from the command line is a little opaque (from the help) because it requires a full path to the .hpf file. The help also contains the term "Pos 0" without making reference to it - however this is outside the scope of this issue.

Steps to Reproduce the problem

Steps to reproduce the behaviour:

  1. Go to command line
  2. Type "Control Center.exe" "profile1.hpf"
  3. Even though profile1.hpf exists in Documents\Helios\Profiles it does not start
  4. Type "Control Center.exe" "%userprofile%\Documents\Helios\Profiles\profile1.hpf"
  5. Profile starts

Expected behavior

The help is unhelpful about the requirements of the argument to start a profile. Control Center should look for the profile in the Helios Profile Directory and the Secondary Profile Directory if it cannot find the profile which has been passed as an argument.

Screenshots

Please complete the following information:

  • Helios Version [1.6.602] (and probably for a very long time before this
  • DCS Version n/a
  • BMS Version n/a

The problem happened while using

(place an 'x' between the square brackets for all that apply)

  • Profile Editor
  • Control Center
  • Keypress Receiver
  • Something else (remember to tell us what it is)

Additional context

Raised by Ratzifutzi on CZ Discord

@BlueFinBima BlueFinBima added the New Issue Label given to issues which have not yet been triaged label Sep 13, 2023
@BlueFinBima BlueFinBima self-assigned this Sep 13, 2023
@Todd1215
Copy link

I use the command line feature as well and agree that the help is not helpful. Probably the Control Center should just look in whatever directory is defined as default or overridden by -d option.

@BlueFinBima
Copy link
Author

BlueFinBima commented Sep 14, 2023

Thanks for the input @Todd1215. I've added some usage examples to the help and tweaked the help text a little. Rather than use the -d, I'm doing a file.exists on supplied profile, if that is false I do a file.exists on the profile directory from the HeliosSettings and if that is false I try a file.exists on the secondary profile directory from the HeliosSettings. If that fails, I assume that the input is rubbish.

Click for images showing the Help

image
image

It would be nice to suppress the default settings in the examples. but I'm struggling to find the right CommandLineParser incantation.

BlueFinBima added a commit that referenced this issue Sep 14, 2023
1) Help text improved and Usage examples added.
2) Attempt is made to find the profile specifided on the command line of the Control Center and Profile editor in the Profile directory and secondary profile directory as taken from the HeliosSettings
@BlueFinBima BlueFinBima added enhancement New feature or request Awaiting Delivery Fixed and awaiting shipment in a new release and removed New Issue Label given to issues which have not yet been triaged labels Sep 17, 2023
@BlueFinBima BlueFinBima added Delivered Code for this issue is in a generally available Helios Release and removed Awaiting Delivery Fixed and awaiting shipment in a new release labels Oct 10, 2023
@BlueFinBima
Copy link
Author

Shipped in 1.6.6030.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Delivered Code for this issue is in a generally available Helios Release enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants