New Quest: trail_visibility

[mcliquid]

Fixes #478

[mcliquid]

For discussion:

• Add gravel|fine_gravel|compacted to the filter?
• Making images bigger? (more than 50%?)

[mnalis]

Add gravel|fine_gravel|compacted to the filter?

I wouldn't add them. If they're man made, with those surfaces it's always going to be trail_visibility=excellent.

Maybe gravel (in cases it is caused by e.g. rockslide and not man-made, but isn't marked as rock instead) might be argued to be included, but I'm hoping that there are not many of those and that percentage of them would be covered by that or (sac_scale and sac_scale != hiking). But even of those majority would be for man-made gravel tracks, so better not to include it either.

Anyway users of SCEE can expand the query for themselves as needed, so it is OK as is, IMHO.

Making images bigger? (more than 50%?)

That would make it painful to scroll, probably. I'm however hoping that perhaps better images could be found / taken. That horrible image for example looks more visible than good. And I doubt that even if picture were to take whole screen of mobile phone would fix the issue (even on laptop screen, most of the pics after excellent do not look very different from one another to me)

[mnalis]

(FYI @mcliquid I've changed PR text to say "fixes #478" instead of "fix for #478", to use magic keyword which automatically resolves the issue when PR gets merged)

[Helium314]

even on laptop screen, most of the pics after excellent do not look very different from one another to me

I agree on this, the images are not particularly helpful for me.
It seems rather tricky to capture something like "Path sometimes invisible, route partly pathless" on a photo and still have it clear in the quest form.

[mcliquid]

Hm, should we remove the images and go with a text only quest form?
I guess it wouldn't be possible to find the "perfect" matching images when I read the latest discussion.

[Helium314]

Hm, should we remove the images and go with a text only quest form? I guess it wouldn't be possible to find the "perfect" matching images when I read the latest discussion.

I agree finding good images would be very hard if possible at all.
Maybe text-only is better as in not tempting users to just go by images.

The texts for excellent and good contain markers, which are not mentioned in the other entries. I would be useful to mention them more consistently, or maybe just "no markers" for the best visibility that has no markers any more.

[mcliquid]

I agree finding good images would be very hard if possible at all.

Another user suggested alternative images here, are these possibly more suitable?
https://wiki.openstreetmap.org/wiki/Talk:Key:trail_visibility#Alternative_Pictures

Maybe text-only is better as in not tempting users to just go by images.

Here would be the quest without pictures, only with text. No idea why the last two entries are indented.
https://github.com/Helium314/SCEE/assets/3351668/fed931f8-95ca-457c-b747-a84818b37952

The texts for excellent and good contain markers, which are not mentioned in the other entries. I would be useful to mention them more consistently, or maybe just "no markers" for the best visibility that has no markers any more.

I've added "no markers" to all other items.

[mcliquid]

@Helium314 Can you guide me how to solve the merge conflict with the strings_ee.xml file?

[mcliquid]

Current version:
https://github.com/Helium314/SCEE/assets/3351668/e0ad66f2-814a-4c8e-b9a5-699baac27431

[mcliquid]

Can you guide me how to solve the merge conflict with the strings_ee.xml file?

fixed it

[mcliquid]

@Helium314 What do you think, ready to merge?

[Helium314]

Quest looks fine now.
Since the images are not used any more they should be removed.

[mcliquid]

Removed all images and tested the app successfully.

[Helium314]

I found some minor things when testing, will add comments to the code

[mcliquid]

Latest version: https://github.com/Helium314/SCEE/assets/3351668/0de2065d-8d96-48fc-9785-d8a1a038e534