-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
potioneffectduration perks cause actions which should lower potion duration to lengthen them instead #1135
Comments
This still present under 1.10.19? |
yeah this is on 1.10.19 |
There was an issue about a similar problem earlier, and the problem was fixed. I think doomgull just misworded it. (You made it) I think this counts as a mod interaction though, since vanilla doesn't usually reduce effect durations- only erasing them with milk. |
Basically. Haven't had a chance to look yet, but this WAS fixed in general, and is likely an interaction with how rustic does the reduction. |
I'm not sure this can be fixed. Responsible code on rustic's end: Which is done because minecraft doesn't allow to "reduce" duration on an existing potion, just by removing and re-adding that potioneffect. It only allows for adding additional duration: So there's not much else to do on rustic's side, and the potion effect duration perks extend newly applied potion effects, so... if that additional duration is more than what the rusic reduction removes, i'm not sure i can fix this as i cannot discern if the newly added potion effect was something that was "just" removed. |
would it be possible for some potion effects to be blacklisted in the config to stop them from being affected by the perk? |
Hi @Doomgull @HellFirePvP , |
Ignoring the perk effects for perks that have a negative effect as defined in code. |
main example is rustic's inebriation potion effect, which starts usually at 8~ minutes, and doesnt do anything unless its level 3 (which happens when you drink too much alcohol)
however, if you drink water bottles, it's supposed to shorten the duration (even clearing it completely if it goes low enough), with potioneffectduration perks this causes lengthening instead.
The text was updated successfully, but these errors were encountered: