refactor code-base variable names and function definitions #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrianArch96
changed the title
HelloMatthewMurphy
approved these changes
Nov 14, 2018
BrianArch96
force-pushed
the
refactoring
branch
from
8514c63
to
8f79243
Compare
ShaneOMalley
requested changes
Nov 14, 2018
| String username = data[5]; | ||
|
|
||
| GregorianCalendar date = new GregorianCalendar(year, month-1, day); | ||
| GregorianCalendar date = new GregorianCalendar(YEAR, MONTH-1, DAY); |
There was a problem hiding this comment.
These are constants which should be passed into certain methods for GregorianCalendar to tell it what info you want etc. They don't actually give you the year, month and day
There was a problem hiding this comment.
Ah I deleted those 3 lines by accident and then was getting errors to the variables not being recognised, my bad :)
| import User.AccountFactory; | ||
| import User.Customer; | ||
| import User.Supervisor; | ||
| import User.*; |
There was a problem hiding this comment.
I'd say you could leave in the individual imports, just to keep it consistent with the rest of the code, and in case something else gets added to the User package
| import ThirdParty.Delivery.Delivery; | ||
| import java.awt.BorderLayout; | ||
| import java.awt.event.WindowEvent; | ||
| import ThirdParty.Delivery.*; |
| @@ -262,18 +251,17 @@ private void LoginEmailActionPerformed(java.awt.event.ActionEvent evt) {//GEN-FI | |||
| private void LoginButtonActionPerformed(java.awt.event.ActionEvent evt) {//GEN-FIRST:event_LoginButtonActionPerformed | |||
| email = LoginEmail.getText(); | |||
| password = LoginPassword.getText(); | |||
| boolean bool = false; | |||
| boolean validation = false; | |||
There was a problem hiding this comment.
isValid might be a better name
| @@ -59,7 +58,7 @@ public void buyStock(String itemBought, int amountBought){ | |||
| /** | |||
| * | |||
| * @param itemName Checks if Item is in warehouse. | |||
| * @return bool | |||
| * @return boolean indicating if shop an item | |||
There was a problem hiding this comment.
uhh, what the fuck? 🤔
BrianArch96
force-pushed
the
refactoring
branch
from
8f79243
to
bb40afd
Compare
Signed-off-by: Brian Archbold <brianarchbold96@yahoo.ie>
BrianArch96
force-pushed
the
refactoring
branch
from
bb40afd
to
fc0d960
Compare
|
Thanks for all the feedback :). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Brian Archbold brianarchbold96@yahoo.ie