Skip to content

Commit

Permalink
fix: allow site access to app.ynab.com (toolkit-for-ynab#3068)
Browse files Browse the repository at this point in the history
* fix: allow site access to app.ynab.com

* fix: ignore protocol, support subdomains
  • Loading branch information
Nick Jones authored and HelloThisIsFlo committed Jun 13, 2023
1 parent 9b61332 commit 11034d7
Show file tree
Hide file tree
Showing 3 changed files with 44 additions and 7 deletions.
15 changes: 13 additions & 2 deletions src/manifest.firefox.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,12 @@
{
"content_scripts": [
{
"matches": ["http://*.youneedabudget.com/*", "https://*.youneedabudget.com/*"],
"matches": [
"http://*.youneedabudget.com/*",
"https://*.youneedabudget.com/*",
"https://*.ynab.com/*",
"http://*.ynab.com/*"
],
"all_frames": true,
"run_at": "document_idle",
"js": ["content-scripts/extension-bridge.js"]
Expand All @@ -22,5 +27,11 @@
"default_title": "Toolkit for YNAB",
"default_popup": "popup/index.html"
},
"permissions": ["http://*.youneedabudget.com/*", "https://*.youneedabudget.com/*", "storage"]
"permissions": [
"http://*.youneedabudget.com/*",
"https://*.youneedabudget.com/*",
"https://*.ynab.com/*",
"http://*.ynab.com/*",
"storage"
]
}
15 changes: 13 additions & 2 deletions src/manifest.ios.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,12 @@
{
"content_scripts": [
{
"matches": ["http://*.youneedabudget.com/*", "https://*.youneedabudget.com/*"],
"matches": [
"http://*.youneedabudget.com/*",
"https://*.youneedabudget.com/*",
"https://*.ynab.com/*",
"http://*.ynab.com/*"
],
"all_frames": true,
"run_at": "document_idle",
"js": ["content-scripts/extension-bridge.js"]
Expand All @@ -23,5 +28,11 @@
"default_title": "Toolkit for YNAB",
"default_popup": "popup/index.html"
},
"permissions": ["http://*.youneedabudget.com/*", "https://*.youneedabudget.com/*", "storage"]
"permissions": [
"http://*.youneedabudget.com/*",
"https://*.youneedabudget.com/*",
"https://*.ynab.com/*",
"http://*.ynab.com/*",
"storage"
]
}
21 changes: 18 additions & 3 deletions src/manifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,12 @@
"version": "3.5.0",
"content_scripts": [
{
"matches": ["http://*.youneedabudget.com/*", "https://*.youneedabudget.com/*"],
"matches": [
"http://*.youneedabudget.com/*",
"https://*.youneedabudget.com/*",
"https://*.ynab.com/*",
"http://*.ynab.com/*"
],
"all_frames": true,
"run_at": "document_idle",
"js": ["content-scripts/extension-bridge.js"]
Expand All @@ -25,7 +30,12 @@
"web_accessible_resources": [
{
"resources": ["assets/*", "web-accessibles/*"],
"matches": ["http://*.youneedabudget.com/*", "https://*.youneedabudget.com/*"]
"matches": [
"http://*.youneedabudget.com/*",
"https://*.youneedabudget.com/*",
"https://*.ynab.com/*",
"http://*.ynab.com/*"
]
}
],
"background": {
Expand All @@ -43,5 +53,10 @@
"default_popup": "popup/index.html"
},
"permissions": ["storage"],
"host_permissions": ["http://*.youneedabudget.com/*", "https://*.youneedabudget.com/*"]
"host_permissions": [
"http://*.youneedabudget.com/*",
"https://*.youneedabudget.com/*",
"https://*.ynab.com/*",
"http://*.ynab.com/*"
]
}

0 comments on commit 11034d7

Please sign in to comment.