Only raise security error on ../ #1453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anoadragon453
force-pushed
the
anoa/fix_filepaths
branch
from
05e90a8
to
4d25a02
Compare
|
@HelloZeroNet Looks simple & promising. Can you merge this please? |
|
Yeah, looking good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've found that some files, such as http://127.0.0.1:43110/ZeroLSTN.bit/merged-ZeroLSTN2/1HLqL1eSZTRMpKLXjprjy7hFftuoAZEz1u/data/users/1GP11T6BYKsTz63srBNo43iTjZaX461o3i/artwork/Drunksouls_On_verra_plus_tard_....jpeg, raise a security error because ZeroNet thinks we're trying to escape from our sandboxed folder.
As far as I can tell, escape can only be had with
../in a filepath, not just.., therefore I've changed this to be more specific in what it catches.This allows these files to load successfully. As far as I can tell it does not open up any security vulnerabilities.