Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Categorize configs #293

Merged
merged 2 commits into from
Aug 22, 2023
Merged

Categorize configs #293

merged 2 commits into from
Aug 22, 2023

Conversation

smannist
Copy link
Contributor

Attempt to categorize the configurations a bit so its easier to tell which parameters belong to which queries etc.

@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Merging #293 (2603fa8) into main (47e0404) will decrease coverage by 0.15%.
The diff coverage is 69.23%.

❗ Current head 2603fa8 differs from pull request most recent head c02acae. Consider uploading reports for the commit c02acae to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #293      +/-   ##
==========================================
- Coverage   80.68%   80.54%   -0.15%     
==========================================
  Files          55       55              
  Lines        1450     1444       -6     
  Branches      167      167              
==========================================
- Hits         1170     1163       -7     
- Misses        256      257       +1     
  Partials       24       24              
Files Changed Coverage Δ
recommender-back/src/apis/aqi.py 21.59% <0.00%> (-0.25%) ⬇️
recommender-back/src/apis/forecast.py 85.95% <ø> (ø)
recommender-back/src/app.py 88.88% <ø> (ø)
recommender-back/src/apis/current.py 93.58% <100.00%> (ø)
recommender-back/src/config.py 100.00% <100.00%> (ø)
recommender-back/src/routes.py 59.49% <100.00%> (ø)

Copy link
Contributor

@isakpulkki isakpulkki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@isakpulkki isakpulkki merged commit 2ef0585 into main Aug 22, 2023
4 checks passed
@isakpulkki isakpulkki deleted the smannist/configclean branch August 22, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants