Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jonij/fix cors issues #295

Merged
merged 3 commits into from
Aug 21, 2023
Merged

Jonij/fix cors issues #295

merged 3 commits into from
Aug 21, 2023

Conversation

JoJoensuu
Copy link
Contributor

fixes #294
Updated pouta documentation.
Added command to start up ubuntu_default network in pouta.
Security update: turned off backend's debug mode in production.
generate_local_env.sh sets debug more to true in local development.

@JoJoensuu JoJoensuu self-assigned this Aug 21, 2023
@JoJoensuu JoJoensuu removed their assignment Aug 21, 2023
@JoJoensuu JoJoensuu marked this pull request as ready for review August 21, 2023 16:51
@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Merging #295 (51e96a6) into main (c19ff32) will not change coverage.
The diff coverage is n/a.

❗ Current head 51e96a6 differs from pull request most recent head e19360c. Consider uploading reports for the commit e19360c to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #295   +/-   ##
=======================================
  Coverage   80.58%   80.58%           
=======================================
  Files          55       55           
  Lines        1442     1442           
  Branches      167      167           
=======================================
  Hits         1162     1162           
  Misses        256      256           
  Partials       24       24           
Files Changed Coverage Δ
recommender-back/src/app.py 88.88% <ø> (ø)

Copy link
Contributor

@smannist smannist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job

@smannist smannist merged commit cf45774 into main Aug 21, 2023
4 checks passed
@isakpulkki isakpulkki deleted the jonij/fix-cors-issues branch August 22, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Broken CORS in /admin
2 participants