Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AQI to scoring and changed field order in forecast weather data #296

Merged
merged 5 commits into from
Aug 21, 2023

Conversation

smannist
Copy link
Contributor

  • Score air quality index
  • Switched wind speed and humidity fields in forecast to match current

@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Merging #296 (0f46dae) into main (55ff0fe) will increase coverage by 0.10%.
The diff coverage is 100.00%.

❗ Current head 0f46dae differs from pull request most recent head 340cbaa. Consider uploading reports for the commit 340cbaa to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #296      +/-   ##
==========================================
+ Coverage   80.58%   80.68%   +0.10%     
==========================================
  Files          55       55              
  Lines        1442     1450       +8     
  Branches      167      167              
==========================================
+ Hits         1162     1170       +8     
  Misses        256      256              
  Partials       24       24              
Files Changed Coverage Δ
recommender-back/src/apis/forecast.py 85.95% <ø> (ø)
recommender-back/src/apis/poi.py 100.00% <ø> (ø)
recommender-back/src/tests/apis/manager_test.py 94.44% <ø> (ø)
...mmender-back/src/services/scoring/indoor_scorer.py 93.93% <100.00%> (+0.18%) ⬆️
...mender-back/src/services/scoring/outdoor_scorer.py 93.93% <100.00%> (+0.18%) ⬆️
recommender-back/src/tests/apis/poi_test.py 95.65% <100.00%> (ø)
...k/src/tests/services/scoring/indoor_scorer_test.py 100.00% <100.00%> (ø)
.../src/tests/services/scoring/outdoor_scorer_test.py 100.00% <100.00%> (ø)

Copy link
Contributor

@JuusoSaavalainen JuusoSaavalainen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@JuusoSaavalainen JuusoSaavalainen merged commit 47e0404 into main Aug 21, 2023
4 checks passed
@smannist smannist deleted the scoreaqi branch August 22, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants