Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AQI unit testing #298

Merged
merged 3 commits into from
Aug 26, 2023
Merged

AQI unit testing #298

merged 3 commits into from
Aug 26, 2023

Conversation

smannist
Copy link
Contributor

Adds a few tests for functions related to aqi

@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #298 (51809d2) into main (eb95e2e) will increase coverage by 2.98%.
The diff coverage is 100.00%.

❗ Current head 51809d2 differs from pull request most recent head f724f03. Consider uploading reports for the commit f724f03 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #298      +/-   ##
==========================================
+ Coverage   80.55%   83.53%   +2.98%     
==========================================
  Files          55       56       +1     
  Lines        1445     1488      +43     
  Branches      169      170       +1     
==========================================
+ Hits         1164     1243      +79     
+ Misses        257      219      -38     
- Partials       24       26       +2     
Files Changed Coverage Δ
recommender-back/src/tests/apis/aqi_test.py 100.00% <100.00%> (ø)
recommender-back/src/tests/apis/manager_test.py 95.45% <100.00%> (+1.01%) ⬆️

... and 2 files with indirect coverage changes

Copy link
Contributor

@Sidorow Sidorow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and tests pass locally.

@Sidorow Sidorow merged commit f9cb52f into main Aug 26, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants