Implement redux #42
Merged
Implement redux #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 3, 2021 14:01
…in boolean in store. Remove old statehacks and dependencies.
bjarneo
approved these changes
Oct 3, 2021
|
I will look into that bug. Thanks. Really appreciate this PR. Will most likely add more features that are using redux, so will look into splitting the reducers at that point. |
bjarneo
pushed a commit
that referenced
this pull request
Jun 8, 2024
* Add redux, react-redux and some basic structure for it. Hold user login boolean in store. Remove old statehacks and dependencies. * Cleanup and refactor Co-authored-by: Taneli Riihimäki <taneli.riihimaki@liveto.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#40
I just used the root reducer to store the login status, should be split into multiple files if you find further use for redux.
Sidenote: Found a minor bug while making this.
Steps to replicate:
-> the component is showing and there is no redirect.
Thought my additions were the reason, but tested it in
mainbranch too with same results.