Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Music player: album art with a non 1:1 aspect ratio breaks the narrow header #22

Closed
HenkKalkwater opened this issue Jul 23, 2022 · 2 comments · Fixed by #23
Closed

Music player: album art with a non 1:1 aspect ratio breaks the narrow header #22

HenkKalkwater opened this issue Jul 23, 2022 · 2 comments · Fixed by #23
Assignees
@HenkKalkwater
Labels
bug Something isn't working platform:sailfishos Issues only on occuring SailfishOS

Comments

@HenkKalkwater
Copy link
Member

@HenkKalkwater HenkKalkwater added bug Something isn't working platform:sailfishos Issues only on occuring SailfishOS labels Jul 23, 2022
@HenkKalkwater
Copy link
Member Author

Related UI issue: text overflow if the artist name is very long: Capture d'écran_20220723_003

@HenkKalkwater HenkKalkwater self-assigned this Jul 23, 2022
@HenkKalkwater
Copy link
Member Author

The alternative to the right align in the PageHeader seems to be to enable wrapping. That makes the layout even worse.

As a solution, I will pretend the second "bug" is not a bug until someone reports it again on the bug tracker ;)

HenkKalkwater added a commit that referenced this issue Jul 23, 2022
@HenkKalkwater
Code deduplication and bug fix
985a651 
Deduplicated code in the NarrowAlbumCover and WideAlbumCover.

Additionally, this fixes a bug where the NarrowAlbumCover would behave
wrongly with album covers with an aspect ratio not equal to 1.0.

Resolves #22
@HenkKalkwater HenkKalkwater mentioned this issue Jul 23, 2022
Merged
@HenkKalkwater HenkKalkwater linked a pull request Jul 23, 2022 that will close this issue
Code deduplication and bug fix in the album cover #23
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HenkKalkwater HenkKalkwater

Labels
bug Something isn't working platform:sailfishos Issues only on occuring SailfishOS
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Code deduplication and bug fix in the album cover heartfin/harbour-sailfin
1 participant
@HenkKalkwater