New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
seg038.cpp demystified + 3 bug fixes + work on status bits + more small changes #52
Open
siebenstreich
wants to merge
108
commits into
Henne:bright_eyes
Choose a base branch
from
siebenstreich:bright_eyes
base: bright_eyes
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original-bug fixed: at two places, (new_y > 23) was tested twice and (new_x > 23) was missing. Original-bug fixed: frozen fight involving fleeing two-fielded monsters. Fix as discussed in https://www.crystals-dsa-foren.de/showthread.php?tid=5191&pid=165957#pid165957 potential Original-bug fixed: uninitialized variable might cause trouble, see https://www.crystals-dsa-foren.de/showthread.php?tid=5383&pid=155007#pid155007
In part based on https://www.crystals-dsa-foren.de/showthread.php?tid=5383&pid=155061#pid155061 unified 'unc' vs. 'uncon' to 'unconscious' Lengthened a few names for better understanding (for example 'cham' -> 'chamaelioni')
…uares monsters". Previous attempt resulted in frozen fight in every turn of a two-squares monster. Fix as discussed in https://www.crystals-dsa-foren.de/showthread.php?tid=5191&pid=165957#pid165957
Strange situation: Heros can enter squares with dead tails, but not cross them. Enemies cannot enter them at all. Moreover, these dead tails are invisible. bug fix: Make these squares walkable in FIG_find_path_to_target See discussion at https://www.crystals-dsa-foren.de/showthread.php?tid=5191&pid=166075#pid166075
…cted move square in the fight.
…onfused with FIGHTER before.
…02.cpp (monster spells).
… into MONSTER_IS_ANIMAL. work on spells continued.
…onsistency and meaning. Before: 'hero_cursed' was hero under Boeser Blick; enemy_cursed was enemy stalled (final fight); 'enemy_bb' was enemy under Boeser Blick.
…ilty and to avoid ambiguity. alchemical brewing process tidied up.
…mage calculation. (Original-Bug 32)
…timers. (Original-Bug 39)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.